feat: replace instruments table with the new dynamic material table #1793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/SciCatProject/frontend into SWAP-4585-replace-instruments-table
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @martin-trajanovski - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the table configuration logic into a separate service or utility function to improve readability and maintainability.
- The component now fetches data on every query parameter change; consider debouncing or throttling these requests to avoid excessive API calls.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/app/instruments/instruments-dashboard/instruments-dashboard.component.ts
Show resolved
Hide resolved
src/app/instruments/instruments-dashboard/instruments-dashboard.component.ts
Show resolved
Hide resolved
src/app/instruments/instruments-dashboard/instruments-dashboard.component.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the instruments table with the new dynamic material table component
Motivation
All the existing tables should be replaced by the new dynamic material table for better performance, flexibility and alignment.
Fixes:
Please provide a list of the fixes implemented in this PR
Changes:
Please provide a list of the changes implemented by this PR
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
Replaces the instruments table with the new dynamic material table component, and refactors the proposal dashboard to use the new dynamic material table component.
Enhancements:
Summary by Sourcery
Replace the existing instruments table with a new dynamic material table component, improving performance, flexibility, and user experience
New Features:
Enhancements:
Tests: